ESMv0.5.0: changes to CMEPS to enable atm-wav coupling in Sofar ESM#8
Open
miguelsolanocordoba wants to merge 54 commits intomainfrom
Open
ESMv0.5.0: changes to CMEPS to enable atm-wav coupling in Sofar ESM#8miguelsolanocordoba wants to merge 54 commits intomainfrom
miguelsolanocordoba wants to merge 54 commits intomainfrom
Conversation
add shared directory to cmake build
added new CMakeLists.txt file for shared directory
provide information about file sources
adding some instructions for building
added for clarity
adding sofar file
new, but seems like a necessary change
add include directories for shared library
create template for makefile fragment
simplifying
These probably won't change
rebase to head
synching with forked source
merge with upstream main
rebase to upstream main
merge upstream main
StevePny
requested changes
Mar 25, 2025
Collaborator
StevePny
left a comment
There was a problem hiding this comment.
As with the other repos, this should be merged into dev/buildfix and not main. That will highlight the changes that are relevant with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR modifies the CMEPS mediator in order to be able to run Sofar's atmosphere-wave coupled ESM and adds masking options for run-time configuration (esm_run.config) that avoid need to re-build the entire Sofar ESM for testing. It solves the these issues [1,2], which are described in more detail here.
Specific notes
Contributors other than yourself, if any:
@StevePny
CMEPS Issues Fixed (include github issue #):
resolves esm-run-scripts#183
resolves esm-run-scripts#191
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Yes. Although coupling in Sofar ESM was running (without external forcing for WW3), the output produced was empty due to the masking issue. Fields are now produced with a standard configuration, which makes srcMaskWav=1, and sets the remaining values to ispval (default-> no masking).
Any User Interface Changes (namelist or namelist defaults changes)?
No
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
Several cases where tested, changing the values of srcMaskAtm, dstMaskAtm, srcMaskWav and dstMaskWav, which as of this PR can be changed at runtime. Setting srcMaskAtm=1 (masking land from field exported by ATM) causes a segmentation fault. The two cases tested to work, involve setting all masks to ispaval (-987987) or changing only the srcMaskWav=1 (i.e. masking wave fields (charnock) over land), which yield similar but not identical results.